@techee commented on this pull request.


In src/symbols.c:

> +	if (sci_get_line_from_position(sci, pos_next) == line)
+		char_width = SSM(sci, SCI_POINTXFROMPOSITION, 0, pos_next) - x;

Maybe it was mentioned somewhere in the previous conversation but what's the point of calculating char_width? Couldn't the rect width just be always 1? Clearly the height is important so the menu is below the line but with width 1 the menu pops up from the gap between characters which looks fine and not unexpected IMO.


Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <geany/geany/pull/3316/review/1665169198@github.com>