@kugel- commented on this pull request.


In src/pluginextension.h:

> +	gboolean (*goto_perform)(GeanyDocument *doc, gint pos, gboolean definition, gpointer data);
+
+	/**
+	 * Pointer to function called by Geany to check whether the plugin implements
+	 * additional symbol (e.g. type) highlighting in Scintilla.
+	 *
+	 * @see @c autocomplete_provided() for more details.
+	 * @note There is no function in the @c PluginExtension structure informing
+	 * plugins to perform symbol highlighting. Plugins
+	 * implementing symbol highlighting should perform it at the appropriate
+	 * moments based on Scintilla and Geany events such as when the document
+	 * becomes visible or when the document is modified.
+	 *
+	 * @since 2.1
+	 **/
+	gboolean (*symbol_highlight_provided)(GeanyDocument *doc, gpointer data);

IMO this is a recipe for getting it wrong. Why doesn't Geany define "appropriate moments based on Scintilla and Geany events" and calls a symbol_highlight_perform() then?


Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <geany/geany/pull/3849/review/2150047412@github.com>