@elextr commented on this pull request.


In src/highlighting.c:

> +				/* FIXME: this is sub-stylable, but we can't figure out the base
+				 * style without the Scintilla instance -- and we can't simply
+				 * assume that if the style ID is larger than the max possible
+				 * one it's this, because SCE_C_IDENTIFIER is also sub-stylable... */

Also, don't we only instantiate one lexer per sci instance? So the whole process needs to be done every time a new tab with a new filetype is opened because there is now a new type of lexer to query?


Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <geany/geany/pull/3794/review/1948585618@github.com>