This is a RFC:
currently, the Windows installer offers to automatically install the bundled GTK runtime environment or to skip the installation of the corresponding files. Actually, this option refers not only to the GTK runtime environment but also to the C/C++ runtime environment (libgcc_s_dw2-1.dll, libstdc++-6.dll, libwinpthread-1.dll) but this is not mentioned in the installer.
Some days ago, a Geany user reported this fact via PM to me, it is also reported in #976.
https://github.com/geany/geany/commit/acd4a92199e03b65a3f099cdc785bae89e379f... will include the necessary C runtime libraries into the base installation, without any chance for the user to disable it. That way users still have to choice to use a seperate GTK stack but don't need to think about the C runtime.
https://github.com/geany/geany/commit/d92c690e6e24f6c15752818f85782bb7b8d5a7... will keep installing the bundled C runtime only when also the bundled GTK runtime is installed. But the title as well as the description of the option to omit installing those files is reworded to make more clear this affects the C *and* GTK runtime and skipping them might cause problems.
I don't have a strong opinion on which way we want to go, but certainly the current situation need to be improved.
Please do not merge yet. Both commits are mutually exclusive, we should merge only one of them.
Fixes #976. You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/1108
-- Commit Summary --
* Windows installer: Add C runtime libraries to default installation * Windows installer: Reword C and GTK dependency information
-- File Changes --
M geany.nsi.in (8)
-- Patch Links --
https://github.com/geany/geany/pull/1108.patch https://github.com/geany/geany/pull/1108.diff
--- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1108