On Wed, Jan 17, 2018 at 09:28:48PM +0000, Colomban Wendling wrote:<br>
&gt; @hyperair I&#39;d like to keep GTK2 support on WebHelper if possible, and I know<br>
&gt; I&#39;ve started (but not finished) this somewhere, I&#39;ll try to find it, compare<br>
&gt; with your changes and see if I find it reasonable to have support for both, or<br>
&gt; if you&#39;re right and it would be too much of a hassle. Also, if Debian is also<br>
&gt; switching to GTK3 Geany, it might suggest no distro is still using the GTK2<br>
&gt; one and that it might be time to let go of the most complex GTK2<br>
&gt; compatibility. I&#39;ll see.<br>
<br>
I&#39;ve already switched the Geany package in Debian to gtk3. Unfortunately, the<br>
new plugins package is still stuck in NEW. I&#39;ll update the PPA shortly after I<br>
finish working on this port too.<br>
<br>
If you want to keep gtk2 after all, elextr&#39;s suggestion of splitting the plugin<br>
into separate gtk2 and gtk3 versions might make sense.<br>
<br>
&gt; And thanks for your work here, looks promising :)<br>
<br>
:) Thanks, good to know.<br>
<br>
&gt; Anyway, it&#39;d be nice to split this PR in 2, one for each plugin, especailly as<br>
&gt; it&#39;s 2 separate maintainers that might have different views on supporting GTK2<br>
&gt; or not :)<br>
<br>
I thought about doing that at first, but I suspect that there may be symbol<br>
clashes between webkitgtk-1.0 and webkit2gtk-4.0, so loading plugins using<br>
different webkit libraries into the same instance of Geany may end badly.<br>
<br>
-- <br>
Kind regards,<br>
Loong Jin<br>


<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany-plugins/pull/677#issuecomment-358566833">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJ9i9g9_UrnmGsC8vXZ-urY-Cz3xOks5tLvlvgaJpZM4RhwhT">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABDrJ2yc4IybYbdIzRzF3YqFCAL9gnf-ks5tLvlvgaJpZM4RhwhT.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/geany/geany-plugins/pull/677#issuecomment-358566833"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany-plugins","title":"geany/geany-plugins","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany-plugins"}},"updates":{"snippets":[{"icon":"PERSON","message":"@hyperair in #677: On Wed, Jan 17, 2018 at 09:28:48PM +0000, Colomban Wendling wrote:\n\u003e @hyperair I'd like to keep GTK2 support on WebHelper if possible, and I know\n\u003e I've started (but not finished) this somewhere, I'll try to find it, compare\n\u003e with your changes and see if I find it reasonable to have support for both, or\n\u003e if you're right and it would be too much of a hassle. Also, if Debian is also\n\u003e switching to GTK3 Geany, it might suggest no distro is still using the GTK2\n\u003e one and that it might be time to let go of the most complex GTK2\n\u003e compatibility. I'll see.\n\nI've already switched the Geany package in Debian to gtk3. Unfortunately, the\nnew plugins package is still stuck in NEW. I'll update the PPA shortly after I\nfinish working on this port too.\n\nIf you want to keep gtk2 after all, elextr's suggestion of splitting the plugin\ninto separate gtk2 and gtk3 versions might make sense.\n\n\u003e And thanks for your work here, looks promising :)\n\n:) Thanks, good to know.\n\n\u003e Anyway, it'd be nice to split this PR in 2, one for each plugin, especailly as\n\u003e it's 2 separate maintainers that might have different views on supporting GTK2\n\u003e or not :)\n\nI thought about doing that at first, but I suspect that there may be symbol\nclashes between webkitgtk-1.0 and webkit2gtk-4.0, so loading plugins using\ndifferent webkit libraries into the same instance of Geany may end badly.\n\n-- \nKind regards,\nLoong Jin\n"}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany-plugins/pull/677#issuecomment-358566833"}}}</script>