@techee commented on this pull request.


In src/editor.c:

> @@ -324,6 +339,18 @@ static gboolean on_editor_button_press_event(GtkWidget *widget, GdkEventButton *
 				keybindings_send_command(GEANY_KEY_GROUP_GOTO, GEANY_KEYS_GOTO_MATCHINGBRACE);
 			return TRUE;
 		}
+		if (event->type == GDK_BUTTON_PRESS && event->state == GDK_MOD1_MASK)

don't use event->state directly (at least not when comparing to equality), because it can contain a whole lot of problematic things (numlock state, etc.). Luckily, there's state already available here :)

Yes, but keybindings_get_modifiers() filters-out Alt (GDK_MOD1_MASK) I wanted to use.


Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <geany/geany/pull/3899/review/2106380031@github.com>