@b4n requested changes on this pull request.

Looks close, but for GTK2 support

In build/markdown.m4:

> @@ -49,8 +49,8 @@ AC_DEFUN([GP_CHECK_MARKDOWN],
     GTK_VERSION=2.16
     WEBKIT_VERSION=1.1.13
 
-    GP_CHECK_GTK3([webkit_package=webkitgtk-3.0],
-                  [webkit_package=webkit-1.0])
+    GP_CHECK_GTK3([webkit_package=webkit2gtk-4.0],
+                    [webkit_package=webkit2gtk-4.0])

This won't work for a GTK2 Geany: webkit2gtk is just not available for GTK2

In markdown/src/viewer.c:

> @@ -300,7 +300,7 @@ static void
 on_webview_load_status_notify(WebKitWebView *view, GParamSpec *pspec,
   MarkdownViewer *self)
 {
-  WebKitLoadStatus load_status;
+  WebKitLoadEvent load_status;
 
   g_object_get(view, "load-status", &load_status, NULL);

webkit2gtk web view doesn't ave a load-status property.

this should be replaced with load-changed and/or load-failed handlers.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.