Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
@b4n commented on this pull request.
In scripts/create_php_tags.py:
>
# write tags
script_dir = dirname(__file__)
tags_file_path = join(script_dir, '..', 'data', 'tags', 'std.php.tags')
- with open(tags_file_path, 'w') as tags_file:
+ with open(tags_file_path, 'w', encoding='iso-8859-1') as tags_file:
So, I guess the remaining difference could be performance, maybe the one is 0.5ms faster than other. For me, the difference cannot be big enough to care if the script is executed every few years :).
Nah, clearly that doesn't matter at all :)
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.