@kugel- commented on this pull request.


In scintilla/gtk/ScintillaGTK.cxx:

> @@ -264,6 +279,12 @@ ScintillaGTK::~ScintillaGTK() {
 	}
 	ClearPrimarySelection();
 	wPreedit.Destroy();
+	if (settingsHandlerId) {
+		g_signal_handler_disconnect(settings, settingsHandlerId);
+	}
+	if (settings) {
+		g_object_unref(settings);

https://sourceforge.net/p/scintilla/code/ci/db178448ae7a1049853c8e6e2cdba6f798ec1ed5/

I guess we can simply remove the unref as the same fix is alredy applied upstream.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.