And if really it needs to be the exact same as the sidebar, the code should indeed be shared rather than copied.
I actually just copied it to avoid more intrusion. I'm just waiting for a go signal so I could place it somewhere else like `utils.c`. How should we share the code? As what I've suggested, we can place it in `utils.h`. Or should we just place it in `sidebar.c` and have `notebook.c` include `sidebar.h`?
Also, should we have add a prefix to `get_doc_folder`? Like `utils_get_doc_folder` or `sidebar_get_doc_folder`?
--- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1144#issuecomment-236382767