With this, you should be able to build src/ and plugins/ warning-free with CFLAGS="-Wall -Wextra -g -Og -Wno-unused-parameter -Wunreachable-code -Wformat=2 -Wundef -Wshadow -Wpointer-arith -Wwrite-strings -Wstrict-prototypes -Wmissing-prototypes -Wmissing-declarations -Wnested-externs -Werror-implicit-function-declaration" (or just -Wall -Wextra -g -Og -Wno-unused-parameter -Wwrite-strings to start with) but for some Lexilla prototype and one deprecated Lexilla call.

To review, go per-commit as it should be fairly trivial that way. Also, everything but maybe 12b30c5 should not be controversial I think -- but please, raise any concern!

You can view, comment on, or merge this pull request online at:

https://github.com/geany/geany/pull/3665

Commit Summary

9592c0b Fix harmless GCC warning
d521ef2 Fix fairly nasty implicit integer conversion
cf73690 "Fix" passing const arguments to spawn functions
3d6f349 Add casts for irrelevant -Wwrite-strings warnings
0b772ef Remove invalid placeholder code
775a83d Use g_*list_free_full() instead of g_*list_foreach()
1dec9bb Avoid an easy-to-fix function cast
593b64f Silence warnings on appropriate GSourceFunc casts
705898d Fix variable shadowing
14d4bb0 Only pass literals as format strings for e.g. printf-style functions
7483c64 Do not use GtkResponseType as response ID type
12b30c5 Silence some -Wcast-function-type warnings

File Changes

(20 files)

Patch Links:

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.