Well, it's better but still not really nice.
| normal | hover -------------------|--------|------ GTK 3.18 |  |  GTK 3.20 |  |  GTK 3.20 + this PR |  | 
I don't really think it's great as is. Both 3.20 versions get the button too close hiding a part of the label, and none make the button really any kind of smaller. With Adwaita at least it doesn't change the tab's effective height, which is good, but we'd have to see with other themes if we really care. And the version in this PR doesn't seem to get the button really smaller, but removes the border when hovering, making the visual clue worse.
I guess the code here is fine, but the CSS needs a little more love.
I can confirm that this change repairs the font on the sci autocomplete popup (without this it uses a proportional font).
That doesn't make sense as nothing in our CSS touches that. Also, it doesn't fix it for me.
--- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/994#issuecomment-212138827