@b4n commented on this pull request.

In scripts/ci_mingw64_geany.sh:

> -		if [ -z "${PATCH}" ] || [ "${PATCH}" = "0" ]; then
-			MINOR="$((MINOR-1))"
-			PATCH="90"
+		if [[ "${MINOR}" = "0" && (-z "${PATCH}" || "${PATCH}" = "0") ]]; then
+			MAJOR="$((MAJOR-1))"
+			MINOR="99"
+			PATCH="99"
 		else
-			PATCH="$((PATCH-1))"
+			if [[ -z "${PATCH}" || "${PATCH}" = "0" ]]; then
+				MINOR="$((MINOR-1))"
+				PATCH="99"
+			else
+				PATCH="$((PATCH-1))"
+			fi
 		fi

Isn't this a simpler version of the exact same thing?

		if [ -z "${PATCH}" ] || [ "${PATCH}" = "0" ]; then
			if [ "${MINOR}" = "0" ]; then
				MAJOR="$((MAJOR-1))"
				MINOR="99"
			else
				MINOR="$((MINOR-1))"
			fi
			PATCH="99"
		else
			PATCH="$((PATCH-1))"
		fi

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <geany/geany/pull/3594/review/1671585291@github.com>