@b4n commented on this pull request.


In src/editor.c:

> @@ -324,6 +339,18 @@ static gboolean on_editor_button_press_event(GtkWidget *widget, GdkEventButton *
 				keybindings_send_command(GEANY_KEY_GROUP_GOTO, GEANY_KEYS_GOTO_MATCHINGBRACE);
 			return TRUE;
 		}
+		if (event->type == GDK_BUTTON_PRESS && event->state == GDK_MOD1_MASK)

Does it? It filters MOD2, but I don't see any kind that it does this for MOD1? Actually quite the contrary, it's in the default modmask for all platforms, and even again for macos (looking at GTK3's gtk_accelerator_get_default_mod_mask() implementation -- and the respective platform vfuncs).


Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <geany/geany/pull/3899/review/2106381928@github.com>