@b4n commented on this pull request.

In src/document.c:

>  
 		if (main_status.main_window_realized)
-			dialogs_show_msgbox(GTK_MESSAGE_WARNING, warn_msg, display_filename);
+			dialogs_show_msgbox(GTK_MESSAGE_WARNING, "%s", warn_msg);
+
+		ui_set_statusbar(TRUE, "%s", warn_msg);

Maybe the format should be taken out of ui_set_statusbar and msgwin_status_add

ui_set_statusbar() has many callers using the formatting feature, and I don't think it's worth adding a specific variant not taking a format but a plain string (quick grep gives me 12 out of 87 calls pass "%s" using this branch).
OTOH we have msgwin_status_add_string(), which I use in the patch.

or the compiler told they are formats and.

What do you mean?

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.