@elextr commented on this pull request.


In scripts/create_php_tags.py:

>  
     # write tags
     script_dir = dirname(__file__)
     tags_file_path = join(script_dir, '..', 'data', 'tags', 'std.php.tags')
-    with open(tags_file_path, 'w') as tags_file:
+    with open(tags_file_path, 'w', encoding='iso-8859-1') as tags_file:

Isn't it the default encoding of PHP? So its what the PHP symbols will be. But tagmangler is a binary format, maybe it should be a binary file?


Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <geany/geany/pull/3488/review/1417684511@github.com>