Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
@dolik-rce commented on this pull request.
In src/ui_utils.c:
> {
- /* Use appropriate function for menu popup:
- - gtk_menu_popup_at_pointer is not available on GTK older than 3.22
- - gtk_menu_popup is deprecated and causes issues on multimonitor wayland setups */
-#if GTK_CHECK_VERSION(3,22,0)
- gtk_menu_popup_at_pointer(GTK_MENU(menu), NULL);
-#else
- gtk_menu_popup(GTK_MENU(menu), NULL, NULL, func, data, button, activate_time);
-#endif
+ if (!sci)
+ gtk_menu_popup_at_pointer(GTK_MENU(menu), NULL);
+ else
You're right. This could be a lot simpler now, that we use only reasonably modern GTK. Actually the only reason why this helper function was created was to hide that ugly #ifdef GTK_CHECK_VERSION(3, 22, 0) in all the places that show menu.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.