Returning large aggregates as values is a potential performance problem, but preventing all aggregate returns is inappropriate because:

1. returning small aggregates that are mostly handled as complete objects as return values often makes code clearer.

2. Modern (well not so modern actually) ABIs allow for small aggregates to be returned in registers, so forcing all returns to memory is actually likely to be slower.

3. if code review does not notice a large aggregate return and nobody notices a performance issue then it doesn't matter

You can view, comment on, or merge this pull request online at:

  https://github.com/geany/geany/pull/1740

Commit Summary

• Remove requirement to fail build on aggregate return

File Changes

• M .travis.yml (2)

Patch Links:

• https://github.com/geany/geany/pull/1740.patch
• https://github.com/geany/geany/pull/1740.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.