Tested on Windows, also against a x86_64 build and works.

However, Geany didn't crash on my system without the change. I still consider the change as correct.

@vlvlbel for my curiosity, how do you build Geany? I assume in a Mingw64 shell against "mingw-w64-x86_64-*" packages? I'm wondering why it didn't crash for me.

For completeness, there are a couple of more occurences with the wrong cast:

geanylua/glspi_sci.c:                   if (len) { scintilla_send_message(doc->editor->sci,SCI_COPYTEXT,len,(glong)content); }
geanymacro/src/geanymacro.c:                    scintilla_send_message(sci,me->message,me->wparam,(glong)clipboardcontents);
geanymacro/src/geanymacro.c:                    me->lparam=(glong)(g_strcompress(s[(*k)++]));
geanymacro/src/geanymacro.c:                            me->lparam=(glong)NULL;
geanymacro/src/geanymacro.c:                    me->lparam=(glong)(g_strcompress(s[(*k)++]));
geanymacro/src/geanymacro.c:            ?((glong) g_strdup((gchar *)(nt->lParam))) : nt->lParam;
geanymacro/src/geanymacro.c:                                    me->lparam=(glong)((cTemp!=NULL)?g_strdup(cTemp):g_strdup(""));
geanymacro/src/geanymacro.c:                                    me->lparam=(glong)(((*cTemp2)==0)?NULL:g_strdup(cTemp2));
geanynumberedbookmarks/src/geanynumberedbookmarks.c:            scintilla_send_message(sci,SCI_MARKERDEFINEPIXMAP,m,(glong)(aszMarkerImages[k]));
git-changebar/src/gcb-plugin.c:  scintilla_send_message (sci, SCI_ADDTEXT, buf_len, (glong) buf);
git-changebar/src/gcb-plugin.c:  scintilla_send_message (old_sci, SCI_ADDTEXT, old_buf_len, (glong) old_buf);

Should we fix those as well?

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.