Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
@b4n commented on this pull request.
In src/document.c:
> if (main_status.main_window_realized) - dialogs_show_msgbox(GTK_MESSAGE_WARNING, warn_msg, display_filename); + dialogs_show_msgbox(GTK_MESSAGE_WARNING, "%s", warn_msg); + + ui_set_statusbar(TRUE, "%s", warn_msg);
which patch?
14d4bb0#diff-d5920a54fc6fff9b49052b09ca50c0608cf55cc93b5a46713bf8a4de1132eed0R1891 but that's irrelevant given I didn't understand what you meant, see below.
My point was that
ui_set_statusbarprintfs the input then callsmsgwin_status_addwith%sto re-printf the result string that it just printfed ((mis)using printf as a verb), so maybe that should usemsgwin_status_add_string()?
Ooh, OK. Indeed, ui_set_statusbar() should call msgwin_status_add_string() instead of msgwin_status_add(). I can add (pun intended) it here, although it's kind of an unrelated optimization.
12 out of 87 calls pass "%s"
Not inconsiderable. In this case you need to printf the string before sending it to the status bar because it is used in the dialog, but since status bar is always doing GTK with the result the cost of re-printfing possibly is immaterial.
Well, I can do an "optimize printf usage" pass and introduce ui_set_statusbar_string(), but as you say I believe it's not gonna matter at the performance level (handling format "%s" is likely pretty trivial, as would be handling formats without placeholders).
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.