I completely forgot about metadata, with this implementation all files given new names are new files, so they have new file metadata. Owner and permissions may change, but specifically the execute bit won't be carried over from the original file. So shell scripts or Python scripts or similar will no longer run until the user manually re-adds the execute.

That was actually the difference that I was trying to realize back then. Yeah, looks like the feature should remain.

Sorry @konsolebox we probably should stick to the existing implementation.

It's ok, this was just a side-concern and it wasn't difficult to make. I'm actually happy with the ideas I'm hearing about this.

Going back to the original issues, do you still think we shouldn't abort saving changes when a rename fails?

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.