Saving document files still needs the options for the reasons explained in my file saving thesis but thats not so relevant to keyfiles.
By the way, one thing the "thesis" doesn't mention is the use of fsync()
which I believe is the cause of #3946. Both g_file_set_contents()
and g_file_replace_contents()
call it but not the fwrite()
method (and maybe we should add it to this method as well to be sure). If something goes wrong during shutdown and sync()
isn't called (which really should happen but things may go wrong), one may lose all the data like in
https://lwn.net/Articles/322823/
(I think this got mitigated in later ext4 versions and isn't as a big problem like in this article)
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.