Ahh, so its a search facility, not really a filter. Would be good, the current search is useless unless you happen to want the first occurrence.

But it turned out to be weird when I tried it and it really should behave as a (permanent until cleared) filter. Some things I discovered in addition:

1. The filter should not probably be applied against just name but the whole scope of a symbol - it's strange to see a class without its members after filtering for its name.
2. The stuff from #3050 should only be applied when filter changes. For C++ classes you get

MyClass::foo()
MyClass::bar()
MyClass::baz()

in the symbol tree because MyClass is defined in the header and its tag isn't present in the source file. That means lots of removals of symbols in the first pass of the symbol tree update when the patch is applied which causes scrolling of the symbol tree when editing file.

Sigh, I thought this would be a nice little patch, quick to apply, and here it comes again :-).

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.