@b4n commented on this pull request.


In src/highlighting.c:

> +				/* FIXME: this is sub-stylable, but we can't figure out the base
+				 * style without the Scintilla instance -- and we can't simply
+				 * assume that if the style ID is larger than the max possible
+				 * one it's this, because SCE_C_IDENTIFIER is also sub-stylable... */

It is, so yeah, we'd have to be sure allocation is the same for all lexer instances. That's the tricky part, then we can just fill something when initially allocating the substyles.

The proper solution should be style = SCI_GETSTYLEFROMSUBSTYLE(style) but we can't do that with this API.


Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <geany/geany/pull/3794/review/1946604092@github.com>