Oh, it was multiple choice 😁

Steps 1,2,3 are fine for this function, step 1 as soon as anybody does it, and as we will need bump the ABI at step 2 it forces a recompile which will fail for any plugins still using the old call, so its all safe.

I read it as intended to be applied to this function only, but obviously it can be applied to any other individual function we want to change the behaviour of.

IIUC what the compile time part does is shrinks the period between steps 2 and 3, a plugin that was only re-compiled at steps 1 and 3 would then be using the new behaviour by accident, so some time is needed, but if a compile time check is also implemented it would allow it to be only one release cycle.

—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you are subscribed to this thread.