@cwendling commented on this pull request.
I don't know much PHP anymore either, but at least the script seems to still work, the difference seem to be in the JSON itself (I only checked a couple things, but they match). Sadly the JSON seems to have a few flaws with the types in signatures (no alternative types, and it seems to use the last one which sometimes is `null` -- that used to be `mixed` in the PHP docs, but now is `foo|bar|baz`), but then again nothing the script can do with that data so I'd think it's fine.
(arg_list, TA_ARGLIST),
(return_type, TA_VARTYPE), (scope, TA_SCOPE)]: if attr is not None: - tag_line += '{type:c}{attr}'.format(type=type, attr=attr) + tag_line += f'{type_:c}{attr}' + print(tag_line)
new debugging, is that wanted?
# write tags script_dir = dirname(__file__) tags_file_path = join(script_dir, '..', 'data', 'tags', 'std.php.tags') - with open(tags_file_path, 'w') as tags_file: + with open(tags_file_path, 'w', encoding='iso-8859-1') as tags_file:
why ISO 8859-1? This seems fully ASCII currently, is this encoding documented somewhere? I can't seem to find out anything in a response header or something.