maybe we could add a short comment in https://github.com/geany/geany/pull/4023/files#diff-42b5b46e89c71a2aee5d52adee0a80fcfa424aad9a00c27a81118279bd64c69aR383 and https://github.com/geany/geany/pull/4023/files#diff-8396dc9c2232193e29aaeddbcf7fa02add25c3c2b855f56c3e5307dc34fcfcf3R1020 to explain why we are doing this

Done, also at the other places.

I noticed if the panes are restored after they have been set to < 10px, the message window pane takes some more space than before (relative to the default window size).
This is probably no big issue because most users will not use the default window size as it is way too small and we can never know what the correct size will be. And after all, this is probably also dependent on the GTK theme. We could use a dynamic ratio based on parent widget allocation but then again, this probably won't fit the users preference.
So it is probably fine as is.

I made it smaller so it's roughly equal to the default value (there seems to be some more complicated way of determining the default value in https://github.com/geany/geany/blob/6ffe16b104e306ec50548bcf032a558ac5b380e0/src/keyfile.c#L1151 but I don't think it's worth it for this case)

After all, I think this is a very good addition to help users to easily restore the panes after they have been (maybe accidentally) hidden by setting the size too small.

Thanks, I have a powerful ally against @elextr :-)

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.