This is my second attempt on the LSP API as originally proposed by #3571.

I changed several things:

I renamed the struct Lsp to PluginExtension - there's nothing LSP-specific in this interface and it could be used by other plugins too (or possibly extended in the future if some plugins wanted to provide another functionality, we could extend this API).
I reduced the number of functions in the API to the absolute minimum and tried to do as much as possible in the plugin itself.
For this PR I removed the API related to the sidebar symbol tree - this one requires most changes on the Geany side and possibly more discussion and I don't want to block this PR by it. One possible alternative is also just keep using TM for the symbol tree, ignoring the symbols provided by LSP (the symbol tree is the least problematic part of TM IMO and could stay the way it is). I'll post the extra patches to allow sidebar symbols in a separate PR.

I also updated the combined Geany+LSP plugin at https://github.com/techee/geany-lsp to use the new API and also to work even when compiled against unmodified Geany. This is quite clumsy, however - to avoid conflicts between Geany's TM implementation and the plugin, it requires disabling TM by adding

[settings]
tag_parser=

to the filetype config file of the affected filetypes, basically disabling all TM features. It also requires separate keybindings for e.g. tag goto or autocompletion instead of re-using the Geany ones.

You can view, comment on, or merge this pull request online at:

https://github.com/geany/geany/pull/3849

Commit Summary

5633fca Add interface used by plugins to replace some Geany functionality with their own implementation
0f11936 Add Geany code delegating autocompletion to plugins
911963a Add Geany code delegating calltips to plugins
b53a8e3 Add Geany code delegating symbol goto to plugins
6db24b8 Add Geany code delegating keyword highlighting to plugins

File Changes

(10 files)

Patch Links:

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.