I think that first of all we should fix the code so that it doesn't only rely on the UI being insensitive not to crash. At least, do something like this:

diff --git a/src/plugins.c b/src/plugins.c
index 32a0ee891..c036ea0dd 100644
--- a/src/plugins.c
+++ b/src/plugins.c
@@ -1865,7 +1865,10 @@ static void pm_on_plugin_button_clicked(G_GNUC_UNUSED GtkButton *button, gpointe
             if (GPOINTER_TO_INT(user_data) == PM_BUTTON_CONFIGURE)
                 plugin_show_configure(&p->public);
             else if (GPOINTER_TO_INT(user_data) == PM_BUTTON_HELP)
+            {
+                g_return_if_fail(p->cbs.help != NULL);
                 p->cbs.help(&p->public, p->cb_data);
+            }
             else if (GPOINTER_TO_INT(user_data) == PM_BUTTON_KEYBINDINGS && p->key_group && p->key_group->plugin_key_count > 0)
                 keybindings_dialog_show_prefs_scroll(p->info.name);
         }

Then, I'll try and play with this to see if we're not doing something wrong somewhere, because it looks like a very odd bug, and it only happens when double-clicking on the checkmark. Also, we really should be using the treeview's cursor rather than the selection, but well.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.