@xiota commented on this pull request.


In updatechecker/src/updatechecker.c:

> @@ -185,15 +191,30 @@ version_compare(const gchar *current_version)
 }
 
 
-static void update_check_result_cb(SoupSession *session,
-    SoupMessage *msg, gpointer user_data)
+static gchar *bytes_to_string(GBytes *bytes)
+{
+    gsize bytes_size = g_bytes_get_size(bytes);
+    gchar *str = g_malloc(bytes_size + 1);
+    memcpy(str, g_bytes_get_data(bytes, NULL), bytes_size);

I don't know any version of libsoup, but wondering why wrap g_bytes_get_data() with another function and memcopy that has to be freed later, rather than g_bytes_get_data() directly, and letting g_bytes_unref() take care of it.


Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <geany/geany-plugins/pull/1336/review/2021421076@github.com>