@b4n commented on this pull request.


In src/pluginextension.c:

> +	g_return_if_fail(ext_name != NULL);
+
+	entry = g_malloc(sizeof *entry);
+	entry->extension = extension;
+	entry->data = data;
+	entry->priority = priority;
+
+	all_extensions = g_list_insert_sorted(all_extensions, entry, sort_extension_entries);
+}
+
+
+/**
+ * Plugins are responsible for calling this function when they no longer
+ * provide the extension, at the latest in the plugin @c cleanup() function.
+ * 
+ * @param extension The @c PluginExtension structure that is being unregistered.

Currently, it has to be the same pointer that was registered, and if it's not one of the registered pointers it's not removing anything.

⬇️ Suggested change
- * @param extension The @c PluginExtension structure that is being unregistered.
+ * @param extension The @c PluginExtension structure pointer to unregister, as previously registered with @c plugin_extension_register()


Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <geany/geany/pull/3849/review/2135431477@github.com>