@techee commented on this pull request.


In src/editor.c:

> +	plugin_extension_calltips_show(editor->document, FALSE);
+	plugin_extension_autocomplete_perform(editor->document, FALSE);

Well, I have just 2 real-world examples to base this on - the LSP plugin and Geany itself. For Geany, both calltips and and autocomplete originate in on_char_added() (except the force variants triggered from elsewhere). For calltips, LSP uses "trigger characters" which, when typed, trigger the calltip display (it's typically ( and ,). Autocompletion also happens as you type and what we call "scope autocompletion" is also based on trigger characters.

One could think of some kind of autocompletion also happen when e.g. deleting characters but I think it would be annoying and don't think anyone does that.

So I think it is reasonably safe to assume on_char_added() is sufficient.


Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <geany/geany/pull/3849/review/2114331402@github.com>