@techee commented on this pull request.


In src/sidebar.c:

> @@ -191,7 +191,7 @@ void sidebar_update_tag_list(GeanyDocument *doc, gboolean update)
 
 	g_return_if_fail(doc == NULL || doc->is_valid);
 
-	if (update)
+	if (update && doc != NULL)

Definitely good to add, this code was actually written by me and I think I just fell into the misunderstanding of the g_return_if_fail() trap above.


Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you are subscribed to this thread.Message ID: <geany/geany/pull/3080/review/842449461@github.com>