@b4n

Actually it is valid for our purpose at least.

I already pointed that out here but as I noted its not documented. Relying on undocumented features seems risky. @techees changes remove that reliance.

set lexer.props.allow.initial.spaces=0 in filetypes.conf, which we probably shouldn't…

Yes we should, to match the parser behaviour you note further on.

For history, the property originates from 00bc23c, which commit message confuses me, as I understand it as meaning the exact contrary to what it actually does…

Well the default value in Scintilla is 1 which matches the comment, but then Geany sets it 0 which is correct (IMNAAHO).

I'm not saying we shouldn't apply your changes here, they do look better to me. I'm just trying to be (too) thorough.

So this is ok and arguing about the lexer prop can occur on another issue/PR, then I agree and LGBI.

@techee thank you for doing a boring repetitive job


Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <geany/geany/pull/3428/c1465343587@github.com>