@eht16 commented on this pull request.


In ctags/gnu_regex/regex_internal.h:

> @@ -418,7 +418,7 @@ static unsigned int re_string_context_at (const re_string_t *input, int idx,
 #define re_string_skip_bytes(pstr,idx) ((pstr)->cur_idx += (idx))
 #define re_string_set_index(pstr,idx) ((pstr)->cur_idx = (idx))
 
-#ifdef WIN32
+#ifdef _WIN32
# git grep -i tagRegexTable ctags/parsers/
ctags/parsers/dosbatch.c:20:static tagRegexTable dosTagRegexTable [] = {
ctags/parsers/dosbatch.c:39:    def->tagRegexTable = dosTagRegexTable;
ctags/parsers/dosbatch.c:40:    def->tagRegexCount = ARRAY_SIZE (dosTagRegexTable);
ctags/parsers/matlab.c:20:static tagRegexTable matlabTagRegexTable [] = {
ctags/parsers/matlab.c:48:      def->tagRegexTable = matlabTagRegexTable;
ctags/parsers/matlab.c:49:      def->tagRegexCount = ARRAY_SIZE (matlabTagRegexTable);

If this detection is sufficient, we have two parsers in Geany using the regex library. For me that doesn't really justify putting efforts into switching the library until there is a need for.


Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <geany/geany/pull/3878/review/2078945427@github.com>