@eht16 commented on this pull request.


In src/ui_utils.c:

>  {
-	/* Use appropriate function for menu popup:
-		- gtk_menu_popup_at_pointer is not available on GTK older than 3.22
-		- gtk_menu_popup is deprecated and causes issues on multimonitor wayland setups */
-#if GTK_CHECK_VERSION(3,22,0)
-	gtk_menu_popup_at_pointer(GTK_MENU(menu), NULL);
-#else
-	gtk_menu_popup(GTK_MENU(menu), NULL, NULL, func, data, button, activate_time);
-#endif
+	if (!sci)
+		gtk_menu_popup_at_pointer(GTK_MENU(menu), NULL);
+	else

Since we need this special case only for the tag completion popup, we might also keep the special logic in smbols.c as before and then we can drop this helper function altogether and use gtk_menu_popup_at_pointer() directly.

What do you think?


Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <geany/geany/pull/3316/review/1152301740@github.com>