Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you are subscribed to this thread.
@techee commented on this pull request.
> @@ -120,7 +120,15 @@ static gboolean init_tag(TMTag *tag, TMSourceFile *file, const tagEntryInfo *tag
tag->name = g_strdup(tag_entry->name);
tag->type = type;
tag->local = tag_entry->isFileScope;
- tag->pointerOrder = 0; /* backward compatibility (use var_type instead) */
+ tag->flags = tm_tag_flag_none_t;
+ if (isTagExtraBitMarked(tag_entry, XTAG_ANONYMOUS))
+ {
+ tag->flags |= tm_tag_flag_anon_t;
+ /* Temporarily store kind letter for anon name generation to flags
+ * as we don't have any other place where to store it. This will
+ * be cleared later in rename_anon_tags() */
+ tag->flags |= (guint)kind_letter << 16;
I wasn't sure if it was OK to add new members to TMTag when it's exposed to plugins. I guess ABI should be bumped in this case?
But I think having the original ctags kind letter would be useful to have in TMTag because once we map it to our TMTagType representation, there's no way back to get the original kind. This might be needed if we decide to generate tags files in the ctags format.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you are subscribed to this thread.