According to b0b0ebb469a6b7eb74d321e6f5d7fe6f0bfcf6ba we guard against proxying the widget more than once for some Windows reasons, but this breaks the case where the same GeanyEntryAction has to re-create a fresh proxy, like when moving the item around.
So, move the guard value to the proxied widget, not the action.
Fixes #3831.
As this is Windows-related (see b0b0ebb469a6b7eb74d321e6f5d7fe6f0bfcf6ba), it could be nice if somebody could actually check that this patch doesn't break anything there. I likely won't, at least in a yearly manner. You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/3838
-- Commit Summary --
* Fix search entry after editing the toolbar
-- File Changes --
M src/geanyentryaction.c (6)
-- Patch Links --
https://github.com/geany/geany/pull/3838.patch https://github.com/geany/geany/pull/3838.diff