@rootkea Can you copy/paste the error/warning message from scan-build gives? (Since that seems to be the main motivation for this change.)

scan-build warned regarding redundant assignment to pos in if expression (line 1060) since on master we reassign to pos at line 1066 without reusing the earlier assigned value.

But now, we are passing the earlier assigned value of pos to strchr() as you suggested so assignment at line 1060 is no longer redundant.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.