@eht16 requested changes on this pull request.
gtk2_package=gtk+-2.0 gtk2_min_version=2.24 gtk3_package=gtk+-3.0 gtk3_min_version=3.0
-PKG_CHECK_EXISTS([$gtk2_package >= $gtk2_min_version], [have_gtk2=yes], [have_gtk2=no]) -PKG_CHECK_EXISTS([$gtk3_package >= $gtk3_min_version], [have_gtk3=yes], [have_gtk3=no]) -AS_IF([test "x$enable_gtk3" = xyes || (test "x$enable_gtk3" != xno && - test "x$have_gtk3" = xyes && - test "x$have_gtk2" = xno)], - [gtk_package=$gtk3_package - gtk_min_version=$gtk3_min_version], - [gtk_package=$gtk2_package - gtk_min_version=$gtk2_min_version]) +AS_IF([test "x$enable_gtk2" = "xyes"], + [PKG_CHECK_MODULES([GTK],
Why the new check with `PKG_CHECK_MODULES`? This seems to cause the linking errors (though no idea why it happens only with Mingw builds).
Without `PKG_CHECK_MODULES`, it works fine for the Mingw build and is closer to the original code: ``` AS_IF([test "x$enable_gtk2" = "xyes"], [gtk_package=$gtk2_package gtk_min_version=$gtk2_min_version], [gtk_package=$gtk3_package gtk_min_version=$gtk3_min_version]) ``` We actually just set the variables for the `PKG_CHECK_MODULES` check further below.