@djhenderson no it still needs specific code for windows unless @eht16 is suggesting throwing the browser setting away and using the app info for all platforms?

He is!
The #2444 does exactly that.

Maybe use the setting if set, else the appinfo, and make the default setting empty, would be a better approach for all platforms (if it works on Macos @techee)? That way it should open help in chrome for me, not Friedfox, yay can uninstall it and not update it.

The idea of the implementation in #2444 is rather to set the initial value of the setting with the appinfo browser and then use the setting.

Anyway, #2444 doesn't work properly on Windows, see #2444 (comment). Not sure why I noticed this earlier :(.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.