@eht16 commented on this pull request.

In scripts/version-bump:

> @@ -23,6 +23,7 @@ s/^\(#define VER_FILEVERSION_STR  *\)[^ ].*$/\1"'"$VER"'"/
 ' -i geany_private.rc
 
 sed -e 's/^\(AC_INIT([^,]*, *\[\)[^]]*\(\],\)/\1'"$VER"'\2/' -i configure.ac
+sed -e 's/^\( *version: *\)[^,]*\(,\)/\1'"\'$VER\'"'\2/' -i meson.build

True. I tried two things already but failed:

include the single quotes in the groups in the regex but failed badly on the proper quoting for shell and sed of single quotes within a single quoted string :(
tried to define the Geany version as variable in meson.build but Meson has a strict policy that the project() must be the very the first instruction in the file. Newer versions of Meson can read the version within the project() call from a command which would give more flexibility but we require an older version which does not support this.

Anyway, I also think this is OK for now. It is "just" the version-bump script which we use only manually and will notice when the regex fails at some later point and can adjust it when needed.

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.