(@elextr fears @techee "trivial", could be up to 3000 lines change :-)

Fear not :-). It's a matter of replacing

https://github.com/techee/geany-lsp/blob/c56de66cecf4dff2c1b1a98ea37b22bd2af73f03/scintilla/gtk/ScintillaGTK.cxx#L1839-L1852

with

int modifierTranslated(int sciModifier) noexcept {
	int translated = 0;
	if (sciModifier & SCMOD_SHIFT)
		translated |= GDK_SHIFT_MASK;
	if (sciModifier & SCMOD_CTRL)
		translated |= GDK_CONTROL_MASK;
	if (sciModifier & SCMOD_ALT)
		translated |= GDK_MOD1_MASK;
	if (sciModifier & SCMOD_SUPER)
		translated |= GDK_MOD4_MASK;
	return translated;
}

(Tested, it works.)

Now, granted, this is for GTK only, there's also Windows and macOS but maybe Neil would accept it even if it weren't possible to implement on other platforms.

In any case, I'd just wait for some feedback here if this is something we want so I don't submit patches upstream that are not used.

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.