@kugel- commented on this pull request.

In src/editor.c:

>  
 static void auto_close_chars(ScintillaObject *sci, gint pos, gchar c)
 {
 	const gchar *closing_char = NULL;
-	gint end_pos = -1;
-
-	if (utils_isbrace(c, 0))
-		end_pos = sci_find_matching_brace(sci, pos - 1);

Right, but this makes autoclose also next to useless (I have it disabled and would welcome improvements). Since autoclosing now only works if Scintilla doesn't see a matching brace autoclosing does not work most of the time. E.g.:

int foo()
{
   if (x) { // !! no autoclose for {, as Scintilla matches the } at the end of the function
}

() is autoclosed in that example, though. So basically as of now autoclosing works reliably only at the end of documents, otherwise it may seem to work only randomly.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.