I added a commit to enable the change history since it was trivial. Seems like a nice, user-visible change to take along (gives a bit of a modern feeling).
I'm a tad late to the party (as usual), but I don't think it should be enabled by default. Here's a few reasons:
- I've seen it do odd stuff (when I ^Zd a change on a line, it stayed green, yet didn't match the saved state), so I'm wondering if it's already stable enough… but maybe it's just because it matched one of the saved states of the file because I did save that previous state before!?
- if you reload the file, everything becomes green…
- if someone doesn't have the marker margin visible, background rendering is quite intrusive (especially after reloading the file 😉 )
- I personally don't understand the point of the feature. Why would I want to see changes since the file was loaded? It's might be nice to see which lines aren't saved, but having everything since the file was loaded I don't understand the use case.
- I think it's not entirely obvious what the feature is about if you don't know it. Meaning that if I just opened Geany, I could wonder what the heck was that thing.
- Colors are a bit off with the default theme (or any for that matter), maybe we'd need some way to adjust that?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <geany/geany/pull/3551/c1751809855@github.com>