@kugel- commented on this pull request.


In src/pluginextension.h:

> +	gboolean (*goto_perform)(GeanyDocument *doc, gint pos, gboolean definition, gpointer data);
+
+	/**
+	 * Pointer to function called by Geany to check whether the plugin implements
+	 * additional symbol (e.g. type) highlighting in Scintilla.
+	 *
+	 * @see @c autocomplete_provided() for more details.
+	 * @note There is no function in the @c PluginExtension structure informing
+	 * plugins to perform symbol highlighting. Plugins
+	 * implementing symbol highlighting should perform it at the appropriate
+	 * moments based on Scintilla and Geany events such as when the document
+	 * becomes visible or when the document is modified.
+	 *
+	 * @since 2.1
+	 **/
+	gboolean (*symbol_highlight_provided)(GeanyDocument *doc, gpointer data);

It makes me sad that significant improvements like that are only available on your lsp plugin. This suggests lots of future new hotness only hits one or the other LSP plugin and Geany's general functionality is left behind. This (colorization of keywords vs types) has always been a (minor) annoyance and I'm wondering why Geany can't do this right (I always assumed that it's a strict Scintilla limitation)?


Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <geany/geany/pull/3849/review/2168100200@github.com>