@techee commented on this pull request.


In src/editor.c:

> +	plugin_extension_calltips_show(editor->document, FALSE);
+	plugin_extension_autocomplete_perform(editor->document, FALSE);

Technically they could be obtained from editor-notify and plugins could call plugin_extension_autocomplete_provided() and plugin_extension_calltips_provided() to check it is them who executes them. But then you have the calls where the force parameter is TRUE and these are still needed. So you'd end up with something like

plugin_extension_calltips_show_force(GeanyDocument *doc);
plugin_extension_autocomplete_perform_force(GeanyDocument *doc);

inside the API and the non-force variants would have to be handled in a separate way outside the API which is quite strange IMO. So I'd leave them as they are.


Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <geany/geany/pull/3849/review/2114299588@github.com>