It turned out this change fixed only one symptom of the real underlying problem:
https://gitlab.gnome.org/GNOME/libxml2/-/issues/255 - some changes in libxml2 2.9.12 in combination with lxml broke the lxml.etree.tostring() method which we also use.
This leads to extra content in the extracted XML elements and this is why we suddenly got non-UTF8 content in the generated GTK doc header (and hence this change was necessary).
Recent nightly builds failed at generating translation files with:

The following files contain translations and are currently not in use. Please
consider adding these to the POTFILES.in file, located in the po/ directory.

doc/geany-gtkdoc.h

but this was also only a symptom because now the generated file contained more than the filtered content by the generation script.

Luckily, libxml2 got a workaround for this bug and Debian already included this workaround in the latest libxml2 package, so future nightly builds on Debian Unstable should work again.

The change in this PR is good anyway and can be kept, I'd say.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.