@b4n commented on this pull request.


In src/editor.c:

> +	if (plugin_extension_calltips_provided(editor->document, NULL))
+		plugin_extension_calltips_show(editor->document, FALSE);
+
+	if (plugin_extension_autocomplete_provided(editor->document, NULL))
+		plugin_extension_autocomplete_perform(editor->document, FALSE);

There's no need to manually call _provided(), at least not anymore, is there?

⬇️ Suggested change
-	if (plugin_extension_calltips_provided(editor->document, NULL))
-		plugin_extension_calltips_show(editor->document, FALSE);
-
-	if (plugin_extension_autocomplete_provided(editor->document, NULL))
-		plugin_extension_autocomplete_perform(editor->document, FALSE);
+	plugin_extension_calltips_show(editor->document, FALSE);
+	plugin_extension_autocomplete_perform(editor->document, FALSE);


Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <geany/geany/pull/3849/review/2111298188@github.com>