You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
@codebrainz commented on this pull request.
In src/search.c:
> @@ -641,27 +643,27 @@ static void create_replace_dialog(void)
label_replace = gtk_label_new_with_mnemonic(_("Replace wit_h:"));
gtk_misc_set_alignment(GTK_MISC(label_replace), 0, 0.5);
- entry_find = gtk_combo_box_text_new_with_entry();
- ui_entry_add_clear_icon(GTK_ENTRY(gtk_bin_get_child(GTK_BIN(entry_find))));
- gtk_label_set_mnemonic_widget(GTK_LABEL(label_find), entry_find);
- gtk_entry_set_width_chars(GTK_ENTRY(gtk_bin_get_child(GTK_BIN(entry_find))), 50);
- ui_hookup_widget(replace_dlg.dialog, entry_find, "entry_find");
- replace_dlg.find_entry = gtk_bin_get_child(GTK_BIN(entry_find));
+ replace_dlg.find_combobox = gtk_combo_box_text_new_with_entry();
+ replace_dlg.find_entry = gtk_bin_get_child(GTK_BIN(replace_dlg.find_combobox));
Isn't this still relying on internal child packing which is not part of the "public" API? For example next minor version they could decide it looks better with a frame around the entry and break it again, right?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.